-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(english contractions): Remove objectionable words (@AnnaBuchholz) #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(english contractions): Remove objectionable words (@AnnaBuchholz) #6230
Conversation
…re already in this file and the British English spellings were already in the britishenglish file)
…d the American spelling was already in this file as well.
…as already in this file and in the britishenglish file)
…if the 25k already had the common American spelling
|
I clearly don't have the best Git proficiency so I don't know why it has a bunch of my old merges and whatnot from other PRs on this PR. I'd be curious to hear why if anyone knows. |
|
Also, is there any particular standard for which words are added to this wordlist? It only has ~200 words and a lot of them have apostrophes (for self-explanatory reasons) and thus don't show up if punctuation is set to false. Also, because it's such a small word list, a good portion of the words have multiple apostrophes (such as fo'c'sle and the quite outrageous y'all'd'n't've). I personally think such words have an outsized impact on this word list and perhaps we could add other contractions to counteract their effect. |
|
I think the two words youre removing in this PR are fine to keep. As for the punctuation issues, I think ill add a special case to the word generation so that these are not removed. As for the weird words like Ill close this PR for now since the words are fine. Feel free to open a new one if you wish to replace the weird words. |
Description
Removed two objectionable words from english_contractions word list.
Checks
Closes #