Skip to content

Conversation

@AnnaBuchholz
Copy link
Contributor

@AnnaBuchholz AnnaBuchholz commented Feb 4, 2025

Description

Removed two objectionable words from english_contractions word list.

Checks

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard.(https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 4, 2025
@AnnaBuchholz
Copy link
Contributor Author

I clearly don't have the best Git proficiency so I don't know why it has a bunch of my old merges and whatnot from other PRs on this PR. I'd be curious to hear why if anyone knows.

@AnnaBuchholz
Copy link
Contributor Author

Also, is there any particular standard for which words are added to this wordlist? It only has ~200 words and a lot of them have apostrophes (for self-explanatory reasons) and thus don't show up if punctuation is set to false. Also, because it's such a small word list, a good portion of the words have multiple apostrophes (such as fo'c'sle and the quite outrageous y'all'd'n't've). I personally think such words have an outsized impact on this word list and perhaps we could add other contractions to counteract their effect.

@Miodec
Copy link
Member

Miodec commented Feb 4, 2025

I think the two words youre removing in this PR are fine to keep. As for the punctuation issues, I think ill add a special case to the word generation so that these are not removed.

As for the weird words like fo'c'sle, we should probably remove them and add some more common ones like you said.

Ill close this PR for now since the words are fine. Feel free to open a new one if you wish to replace the weird words.

@Miodec Miodec closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants